Re: [PATCH v3] of/platform: Unconditionally pause/resume sync state during kernel init

From: Rob Herring
Date: Wed Dec 11 2019 - 15:17:15 EST


On Mon, 9 Dec 2019 11:31:19 -0800, Saravana Kannan wrote:
> Commit 5e6669387e22 ("of/platform: Pause/resume sync state during init
> and of_platform_populate()") paused/resumed sync state during init only
> if Linux had parsed and populated a devicetree.
>
> However, the check for that (of_have_populated_dt()) can change after
> of_platform_default_populate_init() executes. One example of this is
> when devicetree unittests are enabled. This causes an unmatched
> pause/resume of sync state. To avoid this, just unconditionally
> pause/resume sync state during init.
>
> Fixes: 5e6669387e22 ("of/platform: Pause/resume sync state during init and of_platform_populate()")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>
> Reviewed-by: Frank Rowand <frowand.list@xxxxxxxxx>
> ---
>
> v1->v2:
> - Updated the commit text to address Frank's comments
> - Added Frank's R-b
> v2->v3:
> - Added this change log to address Greg's comments
>
> drivers/of/platform.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>

Applied, thanks.

Rob