Re: [PATCH 05/10] tty: serial: samsung_tty: delete samsung.h

From: Krzysztof Kozlowski
Date: Tue Dec 10 2019 - 09:52:09 EST


On Tue, Dec 10, 2019 at 03:37:01PM +0100, Greg Kroah-Hartman wrote:
> There is no need for a .h file for a single .c file, so just move all of
> the content of samsung.h into samsung_tty.c
>
> Cc: Kukjin Kim <kgene@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Cc: Hyunki Koo <kkoos00@xxxxxxxxx>
> Cc: HYUN-KI KOO <hyunki00.koo@xxxxxxxxxxx>
> Cc: Shinbeom Choi <sbeom.choi@xxxxxxxxxxx>
> Cc: Jiri Slaby <jslaby@xxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-samsung-soc@xxxxxxxxxxxxxxx
> Cc: linux-serial@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/tty/serial/samsung.h | 144 -------------------------------
> drivers/tty/serial/samsung_tty.c | 133 +++++++++++++++++++++++++++-
> 2 files changed, 130 insertions(+), 147 deletions(-)
> delete mode 100644 drivers/tty/serial/samsung.h

Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Best regards,
Krzysztof