Re: [Intel-gfx] [PATCH v3 1/2] drm: call drm_gem_object_funcs.mmap with fake offset

From: Daniel Vetter
Date: Fri Dec 06 2019 - 06:10:29 EST


On Fri, Dec 6, 2019 at 11:22 AM Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
>
> On Fri, Dec 06, 2019 at 11:07:24AM +0100, Gerd Hoffmann wrote:
> > On Thu, Dec 05, 2019 at 11:15:23PM +0100, Daniel Vetter wrote:
> > > Looks like unrelated flukes, this happens occasionally. If you're paranoid
> > > hit the retest button on patchwork to double-check.
> > > -Daniel
> >
> > Guess you kicked CI? Just got CI mails, now reporting success, without
> > doing anything. So I'll go push v3 to misc-next.
>
> Oops, spoke too soon. Next mail arrived. Fi.CI.BAT works, but
> Fi.CI.IGT still fails.
>
> Where is the "test again" button? Can I re-run the tests on v2? Right
> now I tend to commit v2 to have a fix committed, then go figure why v3
> fails ...

Top of the mail you get from CI is the link to the patchwork series.
That contains all the same info like in the mail, plus the coveted
button. If failures look similar then yes I guess v3 is somehow
broken. But I've looked, looks like just 2x unrelated noise and you
being unlucky, so imo totally fine to push v3. I'll give CI folks a
heads-up (best done over irc usually).
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch