Re: [PATCH] drm/qxl: remove unnecessary BUG_ON check for handle

From: Gerd Hoffmann
Date: Fri Dec 06 2019 - 05:13:14 EST


On Thu, Dec 05, 2019 at 05:42:31PM -0600, Aditya Pakki wrote:
> In qxl_gem_object_create_with_handle(), handle's memory is not
> allocated on the heap. Checking for failure of handle via BUG_ON
> is unnecessary. This patch eliminates the check.

The check makes sure the caller doesn't pass in handle == NULL
and it is needed.

cheers,
Gerd