Re: [BUGFIX PATCH v2 0/3] selftests: safesetid: Fix some bugs in safesetid test

From: shuah
Date: Thu Dec 05 2019 - 11:45:06 EST


On 12/5/19 9:40 AM, Micah Morton wrote:
On Thu, Dec 5, 2019 at 4:20 AM Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:

Hi,

Here is the v2 series to fix build warnings and erorrs on
kselftest safesetid.
This version includes a fix for a runtime error.

Thank you,

---

Masami Hiramatsu (3):
selftests: safesetid: Move link library to LDLIBS
selftests: safesetid: Check the return value of setuid/setgid
selftests: safesetid: Fix Makefile to set correct test program

These 3 fixes look good, thanks. Were you thinking they would go
through my SafeSetID tree or is there a dedicated one for selftests? I
guess if you're not sure someone else on here can chime in, or I can
just take them through my tree if I don't hear anything.


Yes. There is a linux-kselftest tree dedicated to selftests.
I can take them.




tools/testing/selftests/safesetid/Makefile | 5 +++--
tools/testing/selftests/safesetid/safesetid-test.c | 15 ++++++++++-----
2 files changed, 13 insertions(+), 7 deletions(-)

--

thanks,
-- Shuah