Re: Null pointer crash at find_idlest_group on db845c w/ linus/master

From: Qais Yousef
Date: Wed Dec 04 2019 - 08:56:03 EST


On 12/04/19 14:48, Vincent Guittot wrote:
> if we want to initialize local_sgs, it should be something like
> local_sgs = {
> .avg_load = UINT_MAX,
> .group_type = group_overloaded,
> };

+1

>
> to make sure that we will not select local. This doesn't reflect any
> kind of reality whereas local=NULL is more meaningful and more robust
> IMO

It's just defensive programming from my side :) I don't feel strongly about it
though.

Thanks

--
Qais Yousef