Re: [PATCH v3 1/2] sched/numa: introduce per-cgroup NUMA locality info

From: Randy Dunlap
Date: Tue Dec 03 2019 - 21:33:20 EST


On 12/2/19 10:00 PM, çè wrote:
> diff --git a/init/Kconfig b/init/Kconfig
> index 4d8d145c41d2..9c086f716a6d 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -817,6 +817,15 @@ config NUMA_BALANCING_DEFAULT_ENABLED
> If set, automatic NUMA balancing will be enabled if running on a NUMA
> machine.
>
> +config CGROUP_NUMA_LOCALITY
> + bool "The per-cgroup NUMA Locality"

I would drop "The".

> + default n
> + depends on CGROUP_SCHED && NUMA_BALANCING
> + help
> + This option enable the collection of per-cgroup NUMA locality info,

enables

> + to tell whether NUMA Balancing is working well for a particular
> + workload.
> +
> menuconfig CGROUPS
> bool "Control Group support"
> select KERNFS


--
~Randy
Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>