Re: [PATCH] drm/crtc-helper: drm_connector_get_single_encoder prototype is missing

From: Benjamin Gaignard
Date: Tue Dec 03 2019 - 11:47:40 EST


Le mer. 20 nov. 2019 Ã 00:28, Benjamin GAIGNARD
<benjamin.gaignard@xxxxxx> a Ãcrit :
>
>
> On 11/19/19 7:53 PM, Souza, Jose wrote:
> > On Tue, 2019-11-19 at 13:58 +0100, Benjamin Gaignard wrote:
> >> Include drm_crtc_helper_internal.h to provide
> >> drm_connector_get_single_encoder
> >> prototype.
> >>
> >> Fixes: a92462d6bf493 ("drm/connector: Share with non-atomic drivers
> >> the function to get the single encoder")
> > drm_connector_get_single_encoder() is implemented before the use in
> > this file so it is not broken, no need of a fixes tag.
> >
> > Reviewed-by: Josà Roberto de Souza <jose.souza@xxxxxxxxx>
>
> I will remove fixe tag before push it.
>
> Thanks,
>
> Benjamin

Applied on drm-misc-next with out Fixes tag.
Thanks for the review.

Benjamin

>
> >
> >> Cc: Josà Roberto de Souza <jose.souza@xxxxxxxxx>
> >>
> >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxx>
> >> ---
> >> drivers/gpu/drm/drm_crtc_helper.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/drm_crtc_helper.c
> >> b/drivers/gpu/drm/drm_crtc_helper.c
> >> index 499b05aaccfc..93a4eec429e8 100644
> >> --- a/drivers/gpu/drm/drm_crtc_helper.c
> >> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> >> @@ -48,6 +48,8 @@
> >> #include <drm/drm_print.h>
> >> #include <drm/drm_vblank.h>
> >>
> >> +#include "drm_crtc_helper_internal.h"
> >> +
> >> /**
> >> * DOC: overview
> >> *
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel