Re: [PATCH v4 8/8] linux/log2.h: Use roundup/dow_pow_two() on 64bit calculations

From: Rob Herring
Date: Tue Dec 03 2019 - 10:53:24 EST


On Tue, Dec 3, 2019 at 5:48 AM Nicolas Saenz Julienne
<nsaenzjulienne@xxxxxxx> wrote:
>
> The function now is safe to use while expecting a 64bit value. Use it
> where relevant.

What was wrong with the existing code? This is missing some context.

> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>
> ---
> drivers/acpi/arm64/iort.c | 2 +-
> drivers/net/ethernet/mellanox/mlx4/en_clock.c | 3 ++-
> drivers/of/device.c | 3 ++-

In any case,

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> drivers/pci/controller/cadence/pcie-cadence-ep.c | 3 ++-
> drivers/pci/controller/cadence/pcie-cadence.c | 3 ++-
> drivers/pci/controller/pcie-brcmstb.c | 3 ++-
> drivers/pci/controller/pcie-rockchip-ep.c | 5 +++--
> kernel/dma/direct.c | 2 +-
> 8 files changed, 15 insertions(+), 9 deletions(-)