Re: [PATCH v2] kunit: testing kunit: Bug fix in test_run_timeout function

From: Brendan Higgins
Date: Tue Dec 03 2019 - 01:16:30 EST


On Mon, Dec 2, 2019 at 3:53 PM Heidi Fahim <heidifahim@xxxxxxxxxx> wrote:
>
> Assert in test_run_timeout was not updated with the build_dir argument
> and caused the following error:
> AssertionError: Expected call: run_kernel(timeout=3453)
> Actual call: run_kernel(build_dir=None, timeout=3453)
>
> Needed to update kunit_tool_test to reflect this fix
> https://lkml.org/lkml/2019/9/6/351
>
> Signed-off-by: Heidi Fahim <heidifahim@xxxxxxxxxx>
> Reviewed-by: SeongJae Park <sjpark@xxxxxxxxx>

Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
Tested-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>

Heidi, thanks for taking care of this!

Shuah, can we make sure to get this in as a v5.5 fix?