Re: [PATCH v8 01/13] selftests/resctrl: Add README for resctrl tests

From: Borislav Petkov
Date: Mon Dec 02 2019 - 18:06:54 EST


On Mon, Dec 02, 2019 at 10:53:35AM -0800, Fenghua Yu wrote:
> Babu's major contributions are in v5 where he virtually touched every
> patch. He sent out v5 and put Signed-off-by: Babu Moger in each patch:
> https://lore.kernel.org/patchwork/cover/1033532/
>
> That's why I keep his SOB in v6-v8 in each patch.

For that you either need to use

Co-developed-by: Babu

or state the fact that Babu did contribute to the patches in freetext in
the commit messages.

As it is now, it is not clear what it means. You could've kept the order
from v5 since you took his submission and could've done:

Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>
Signed-off-by: Babu Moger <babu.moger@xxxxxxx>
Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>

to show you're the author, Babu handled them further and you're sending
the patchset now, but the other thing I suggested above is more clear
IMO.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette