Re: [PATCH] mips: Fix gettimeofday() in the vdso library

From: H. Nikolaus Schaller
Date: Fri Nov 29 2019 - 10:09:55 EST



> Am 29.11.2019 um 15:58 schrieb Vincenzo Frascino <vincenzo.frascino@xxxxxxx>:
>
> On 11/29/19 2:52 PM, H. Nikolaus Schaller wrote:
>>
>>> Am 29.11.2019 um 15:36 schrieb Vincenzo Frascino <vincenzo.frascino@xxxxxxx>:
>>>
>>> The libc provides a discovery mechanism for vDSO library and its
>>> symbols. When a symbol is not exposed by the vDSOs the libc falls back
>>> on the system calls.
>>>
>>> With the introduction of the unified vDSO library on mips this behavior
>>> is not honored anymore by the kernel in the case of gettimeofday().
>>>
>>> The issue has been noticed and reported due to a dhclient failure on the
>>> CI20 board:
>>>
>>> root@letux:~# dhclient
>>> ../../../../lib/isc/unix/time.c:200: Operation not permitted
>>> root@letux:~#
>>>
>>> Restore the original behavior fixing gettimeofday() in the vDSO library.
>>>
>>> Cc: Paul Burton <paulburton@xxxxxxxxxx>
>>> Reported-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
>>> Testes-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> # CI20 with JZ4780
>> ^^^ funny typo... -> Tested-by:
>
> Ops, I copy-pasted it from your email ;) Can't trust you ;)

No :)

Well, typos happen and nobody seems to notice. My favourite:

5f9e832c137075045d15cd6899ab0505cfb2ca4b

BR,
Nikolaus