Re: [PATCH 1/2] crypto: atmel-tdes - Set the IV after {en,de}crypt

From: Herbert Xu
Date: Wed Nov 27 2019 - 21:33:21 EST


On Wed, Nov 27, 2019 at 04:56:37PM +0000, Tudor.Ambarus@xxxxxxxxxxxxx wrote:
>
>
> On 11/15/19 3:49 PM, Tudor Ambarus - M18064 wrote:
> > static void atmel_tdes_finish_req(struct atmel_tdes_dev *dd, int err)
> > {
> > struct skcipher_request *req = dd->req;
> > @@ -580,6 +605,8 @@ static void atmel_tdes_finish_req(struct atmel_tdes_dev *dd, int err)
> >
> > dd->flags &= ~TDES_FLAGS_BUSY;
> >
> > + atmel_tdes_set_iv_as_last_ciphertext_block(dd);
>
> ECB mode does not use an IV, I should probably exclude the update of IV for the
> ECB mode. v2 will follow.

Please send an incremental patch as this one has already been
applied.

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt