Re: [PATCH] MIPS: Fix boot on Fuloong2 systems

From: Jiaxun Yang
Date: Wed Nov 27 2019 - 19:42:59 EST




ä 2019å11æ27æ GMT+08:00 äå11:26:12, Guenter Roeck <linux@xxxxxxxxxxxx> åå:
>Commit 268a2d60013049 ("MIPS: Loongson64: Rename CPU TYPES") changed
>Kconfig symbols as follows:
> CPU_LOONGSON2 to CPU_LOONGSON2EF
> CPU_LOONGSON3 to CPU_LOONGSON64
> SYS_HAS_CPU_LOONGSON3 to SYS_HAS_CPU_LOONGSON64
>
>It did not touch SYS_HAS_CPU_LOONGSON2E or SYS_HAS_CPU_LOONGSON2F.
>However, the patch changed a conditional from
>
> #if defined(CONFIG_SYS_HAS_CPU_LOONGSON2E) || \
> defined(CONFIG_SYS_HAS_CPU_LOONGSON2F)
>
>to
>
> #if defined(CONFIG_SYS_HAS_CPU_LOONGSON2EF)
>
>SYS_HAS_CPU_LOONGSON2EF does not exist, resulting in boot failures
>with the qemu fulong2e emulation. Revert to the original code.
>
>Fixes: 268a2d60013049 ("MIPS: Loongson64: Rename CPU TYPES")
>Cc: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
>Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Acked-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>

Apologies for the mistake. I ran some tests before sending the
patch but probably get this missed due to
difference between my local tree and next tree.

Thanks for catching that!
>---

--
Jiaxun Yang