Re: [PATCH v4] crypto: arm64/sha: fix function types

From: Eric Biggers
Date: Wed Nov 27 2019 - 19:25:22 EST


On Wed, Nov 27, 2019 at 03:55:03PM -0800, Sami Tolvanen wrote:
> Instead of casting pointers to callback functions, add C wrappers
> to avoid type mismatch failures with Control-Flow Integrity (CFI)
> checking.
>
> Signed-off-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> Reviewed-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
> ---
> Changes in v4:
> - Removed unnecessary returns.
>
> Changes in v3:
> - Removed unnecessary inline attributes.
>
> Changes in v2:
> - Added wrapper functions instead of changing parameter types
> for the assembly functions.
>

Reviewed-by: Eric Biggers <ebiggers@xxxxxxxxxx>

- Eric