Re: [PATCH] KVM: SVM: Fix "error" isn't initialized

[Haiwei Li]

On 2019/11/27 11:44, Sean Christopherson wrote:
> On Wed, Nov 27, 2019 at 03:30:06AM +0000, linmiaohe wrote:
> > > From: Haiwei Li <lihaiwei@xxxxxxxxxxx>
> > > Subject: [PATCH] initialize 'error'
> > >
> > > There are a bunch of error paths were "error" isn't initialized.
> > Hi,
> > In case error case, sev_guest_df_flush() do not set the error.
> > Can you set the value of error to reflect what error happened
> > in sev_guest_df_flush()?
> > The current fix may looks confused when print "DF_FLUSH failed" with
> > error = 0.
> > Thanks.
> >
> > PS: This is just my personal point.
>
> Disclaimer: not my world at all...
>
> Based on the prototype for __sev_do_cmd_locked(), @error is intended to be
> filled only if there's an actual response from the PSP, which is a 16-bit
> value.  So maybe init @psp_ret at the beginning of __sev_do_cmd_locked() to
> -1 to indicate the command was never sent to the PSP?  And update the
> pr_err() in sev_asid_flush() to explicitly state it's the PSP return?

Thanks for your advise. Good point. I will send a new patch.