Re: [PATCH] m68k: Wire up clone3() syscall

From: Christian Brauner
Date: Tue Nov 26 2019 - 09:41:26 EST


On Mon, Nov 25, 2019 at 10:12:25AM +0100, Geert Uytterhoeven wrote:
> Hi Kars,
>
> On Sun, Nov 24, 2019 at 8:52 PM Kars de Jong <jongk@xxxxxxxxxxxxxx> wrote:
> > Wire up the clone3() syscall for m68k. The special entry point is done in
> > assembler as was done for clone() as well. This is needed because all
> > registers need to be saved. The C wrapper then calls the generic
> > sys_clone3() with the correct arguments.
> >
> > Tested on A1200 using the simple test program from:
> >
> > https://lore.kernel.org/lkml/20190716130631.tohj4ub54md25dys@xxxxxxxxxx/

Please note that we now have a growing test-suite for the clone3()
syscall under
tools/testing/selftests/clone3/*

You can test on a suitable kernel with

make TARGETS=clone3 kselftest

> >
> > Cc: linux-m68k@xxxxxxxxxxxxxxx
> > Signed-off-by: Kars de Jong <jongk@xxxxxxxxxxxxxx>
>
> Thanks a lot!
> Works fine on ARAnyM, too.
>
> Looks good to me, but I'll wait a bit before applying, so the syscall experts
> can chime in, if needed.

Otherwise this looks good to me.
Thanks for moving this forward. One day we'll be able to remove
ARCH_WANT_SYS_CLONE3 completely. :)

Christian