Re: [PATCH] i2c: i2c-cros-ec-tunnel: Fix slave device enumeration

From: Enric Balletbo i Serra
Date: Tue Nov 26 2019 - 05:23:59 EST


Hi,

On 21/11/19 10:06, Akshu Agrawal wrote:
> During adding of the adapter the slave device registration
> use to fail as the acpi companion field was not populated.
>
> Signed-off-by: Akshu Agrawal <akshu.agrawal@xxxxxxx>

Looks good to me.

Reviewed-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>

> ---
> drivers/i2c/busses/i2c-cros-ec-tunnel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> index c551aa96a2e3..aca8070393bd 100644
> --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> @@ -273,6 +273,7 @@ static int ec_i2c_probe(struct platform_device *pdev)
> bus->adap.dev.parent = &pdev->dev;
> bus->adap.dev.of_node = np;
> bus->adap.retries = I2C_MAX_RETRIES;
> + ACPI_COMPANION_SET(&bus->adap.dev, ACPI_COMPANION(&pdev->dev));
>
> err = i2c_add_adapter(&bus->adap);
> if (err)
>