Re: [PATCH] arm: exynos_config: Restore debugfs support

From: Steven Rostedt
Date: Mon Nov 25 2019 - 09:39:36 EST


On Mon, 25 Nov 2019 15:30:39 +0100
Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> wrote:

> It seems that commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS
> dependency") disabled DEBUG_FS also in some other ARM defconfigs.
>
> For some of them it may be a correct change but a preferred way to
> introduce such changes would be to:
>
> - add explicit CONFIG_DEBUG_FS=y instances to all affected defconfigs
> while removing DEBUG_FS selection from TRACING config item
>

I strongly disagree. It was wrong to assume DEBUG_FS is attached to
TRACING. If someone wanted DEBUG_FS in their def config, they should
have added it specifically. The addition of DEBUG_FS to defconfigs no
way belongs to the patch that removed DEBUG_FS from TRACING.

-- Steve


> - let platform maintainers disable DEBUG_FS manually in corresponding
> defconfigs later if desirable