Re: [PATCH v4 06/13] exfat: add exfat entry operations

From: Markus Elfring
Date: Thu Nov 21 2019 - 09:11:54 EST


â
> +++ b/fs/exfat/fatent.c
â
> +int exfat_free_cluster(struct inode *inode, struct exfat_chain *p_chain)
> +{
â
> +out:
> + sbi->used_clusters -= num_clusters;

Can a label like âdecrement_counterâ be more helpful?


â
> +int exfat_mirror_bh(struct super_block *sb, sector_t sec,
> + struct buffer_head *bh)
> +{
â
> + if (!c_bh) {
> + err = -ENOMEM;
> + goto out;
> + }

Can it be nicer to return directly?

â
> +out:
> + return err;
> +}

Would you like to omit such a label for this function implementation?

Regards,
Markus