Re: [PATCH v2 1/1] drm: Prefer pcie_capability_read_word()

From: Bjorn Helgaas
Date: Thu Nov 21 2019 - 08:55:20 EST


On Mon, Nov 18, 2019 at 12:42:25PM -0500, Alex Deucher wrote:
> On Mon, Nov 18, 2019 at 3:37 AM Frederick Lawler <fred@xxxxxxxxxxxx> wrote:
> >
> > Commit 8c0d3a02c130 ("PCI: Add accessors for PCI Express Capability")
> > added accessors for the PCI Express Capability so that drivers didn't
> > need to be aware of differences between v1 and v2 of the PCI
> > Express Capability.
> >
> > Replace pci_read_config_word() and pci_write_config_word() calls with
> > pcie_capability_read_word() and pcie_capability_write_word().
> >
> > Signed-off-by: Frederick Lawler <fred@xxxxxxxxxxxx>
> >
> > ---
> > V2
> > - Squash both drm commits into one
> > - Rebase ontop of d46eac1e658b
> > ---
> > drivers/gpu/drm/amd/amdgpu/cik.c | 63 ++++++++++++++++-----------
> > drivers/gpu/drm/amd/amdgpu/si.c | 71 +++++++++++++++++++------------
> > drivers/gpu/drm/radeon/cik.c | 70 ++++++++++++++++++------------
> > drivers/gpu/drm/radeon/si.c | 73 ++++++++++++++++++++------------
>
> Can you split this into two patches? One for amdgpu and one for radeon?

I split this, and I also went back and split the related patches that
preceded this one. I'll post the resulting series for reference.