Re: [PATCH v2 1/2] pinctrl: rza1: remove unnecessary static inline function

From: Linus Walleij
Date: Thu Nov 21 2019 - 08:33:44 EST


On Wed, Nov 13, 2019 at 8:10 AM Matti Vaittinen
<matti.vaittinen@xxxxxxxxxxxxxxxxx> wrote:

> Having static inline oneliner does not benefit too mucg when it is
> only called from another oneliner function. Remove some of the
> 'onion'. This simplifies also the coming usage of the gpiolib
> defines. We can do conversion from chip bits to gpiolib direction
> defines as last step in the get_direction callback. Drivers can
> use chip specific values in driver internal functions and do
> conversion only once.
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Acked-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
>
> Changes since v1: Subject fixed as pointed out by Geert.

Patch applied.

Yours,
Linus Walleij