Re: [PATCH v4 03/13] exfat: add inode operations

From: Greg Kroah-Hartman
Date: Thu Nov 21 2019 - 06:51:45 EST


On Thu, Nov 21, 2019 at 11:40:28AM +0100, Markus Elfring wrote:
> > + if (err) {
> > + if (err != -ENOSPC)
> > + return -EIO;
> > + return err;
> > + }
>
> Can such source code become more succinct?
>
> + if (err)
> + return err != -ENOSPC ? -EIO : err;

No, the original is best here. Never use ? : if you can ever help it.