Re: [PATCH -next] KVM: x86: remove set but not used variable 'called'

From: Paolo Bonzini
Date: Thu Nov 21 2019 - 04:13:32 EST


On 19/11/19 13:14, Dan Carpenter wrote:
>> Better expressed as
>>
>> Fixes: 7ee30bc132c6 ("KVM: x86: deliver KVM IOAPIC scan request to target vCPUs")
>
> There is sort of a debate about this whether the Fixes tag should be
> used if it's only a cleanup.

The other debate is whether this is a cleanup, since the build is broken
with -Werror. I agree that code cleanups generally don't deserve Fixes
tags, but this patch IMHO does.

Paolo