Re: [PATCH v3] usb: xhci: only set D3hot for pci device

From: Henry Lin
Date: Wed Nov 20 2019 - 20:53:58 EST


>> @@ -770,7 +770,7 @@ static void xhci_stop(struct usb_hcd *hcd)
>> *
>> * This will only ever be called with the main usb_hcd (the USB3 roothub).
>> */
>> -static void xhci_shutdown(struct usb_hcd *hcd)
>> +void xhci_shutdown(struct usb_hcd *hcd)
>> {
>> struct xhci_hcd *xhci = hcd_to_xhci(hcd);
>>
>> @@ -789,10 +789,6 @@ static void xhci_shutdown(struct usb_hcd *hcd)
>> xhci_dbg_trace(xhci, trace_xhci_dbg_init,
>> "xhci_shutdown completed - status = %x",
>> readl(&xhci->op_regs->status));
>> -
>> - /* Yet another workaround for spurious wakeups at shutdown with HSW */
>> - if (xhci->quirks & XHCI_SPURIOUS_WAKEUP)
>> - pci_set_power_state(to_pci_dev(hcd->self.sysdev), PCI_D3hot);
>> }

>Shouldn't this function also now need to be EXPORTed?
Yes. I will add EXPORT_SYMBOL_GPL() for it.