Re: [PATCH 4.19 038/422] soundwire: Initialize completion for defer messages

From: Pierre-Louis Bossart
Date: Wed Nov 20 2019 - 18:32:04 EST



[ Upstream commit a306a0e4a5326269b6c78d136407f08433ab5ece ]

Deferred messages are async messages used to synchronize
transitions mostly while doing a bank switch on multi links.
On successful transitions these messages are marked complete
and thereby confirming that all the buses performed bank switch
successfully.

So, initialize the completion structure for the same.

Signed-off-by: Sanyog Kale <sanyog.r.kale@xxxxxxxxx>

This is only called from sdw_transfer_defer() and that function is
called in mainline, but is unused in 4.19.X.

So I don't think this is suitable for -stable.

Agree.

Multi-link solutions with synchronized streaming are not supported just yet. It's an important feature but it'll only be enabled after the existing backlog of 60+ patches are merged, and when the ASoC multi-cpu support allows for this feature, hopefully for 5.7.

my 2 cents
-Pierre