Re: [PATCH v2] fork: fix pidfd_poll()'s return type

From: Christian Brauner
Date: Wed Nov 20 2019 - 05:52:34 EST


On Wed, Nov 20, 2019 at 01:33:20AM +0100, Luc Van Oostenryck wrote:
> pidfd_poll() is defined as returning 'unsigned int' but the
> .poll method is declared as returning '__poll_t', a bitwise type.
>
> Fix this by using the proper return type and using the EPOLL
> constants instead of the POLL ones, as required for __poll_t.
>
> Fixes: b53b0b9d9a61 ("pidfd: add polling support")
> Cc: Joel Fernandes (Google) <joel@xxxxxxxxxxxxxxxxx>
> Cc: Christian Brauner <christian@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # 5.3
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
> Reviewed-by: Christian Brauner <christian.brauner@xxxxxxxxxx>

Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/log/?h=fixes

Will likely send this as a fix for v5.4 still so stable only has to
backport this to 5.3 and not 5.4 too.

Thanks!
Christian