Re: [PATCH v25 12/12] LRNG - add interface for gathering of raw entropy

From: Stephan Müller
Date: Wed Nov 20 2019 - 04:02:36 EST


Am Dienstag, 19. November 2019, 18:17:55 CET schrieb Randy Dunlap:

Hi Randy,

> Hi,
>
> On 11/16/19 1:38 AM, Stephan Müller wrote:
> > diff --git a/drivers/char/lrng/Kconfig b/drivers/char/lrng/Kconfig
> > index e6ca3acc1e48..4ccc710832ef 100644
> > --- a/drivers/char/lrng/Kconfig
> > +++ b/drivers/char/lrng/Kconfig
> > @@ -169,4 +169,20 @@ config LRNG_APT_CUTOFF
> >
> > default 325 if !LRNG_APT_BROKEN
> > default 32 if LRNG_APT_BROKEN
> >
> > +config LRNG_TESTING
> > + bool "Enable entropy test interface to LRNG noise source"
> > + select CONFIG_DEBUG_FS
>
> That should be spelled as DEBUG_FS and preferably would be "depends on"
> instead of 'select'.

Fixed.

Thank you very much.

Ciao
Stephan