Re: [PATCH v2] loop: avoid EAGAIN, if offset or block_size are changed

From: Bart Van Assche
Date: Tue Nov 19 2019 - 18:41:00 EST


On 5/17/19 5:53 PM, Jaegeuk Kim wrote:
This patch tries to avoid EAGAIN due to nrpages!=0 that was originally trying
to drop stale pages resulting in wrong data access.

Report: https://bugs.chromium.org/p/chromium/issues/detail?id=938958#c38

Please provide a more detailed commit description. What is wrong with the current implementation and why is the new behavior considered the correct behavior?

This patch moves draining code from before the following comment to after that comment:

/* I/O need to be drained during transfer transition */

Is that comment still correct or should it perhaps be updated?

Thanks,

Bart.