Re: [PATCH 1/2] coresight: funnel: Fix missing spin_lock_init()

From: Mathieu Poirier
Date: Tue Nov 19 2019 - 11:15:41 EST


On Mon, 18 Nov 2019 at 21:30, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Mon, Nov 18, 2019 at 11:52:06AM -0700, Mathieu Poirier wrote:
> > From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> >
> > The driver allocates the spinlock but not initialize it.
> > Use spin_lock_init() on it to initialize it correctly.
> >
> > This is detected by Coccinelle semantic patch.
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> > Tested-by: Yabin Cui <yabinc@xxxxxxxxxx>
> > Signed-off-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> > ---
> > drivers/hwtracing/coresight/coresight-funnel.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> Is this, and the 2/2 patch here, needed for stable releases?

No as the code they fix is new to this cycle[1].

Thanks for being inquisitive,
Mathieu

[1]. https://lkml.org/lkml/2019/11/4/726

>
> thanks,
>
> greg k-h