Re: [PATCH 08/10] nvdimm: Add driver for OpenCAPI Storage Class Memory

[Andrew Donnellan]

On 19/11/19 1:48 pm, Alastair D'Silva wrote:
> On Tue, 2019-11-19 at 10:47 +1100, Andrew Donnellan wrote:
> > On 15/11/19 3:35 am, Dan Williams wrote:
> > > > Have you discussed with the directory owner if it's ok to split
> > > > the
> > > > driver over several files?
> > >
> > > My thought is to establish drivers/opencapi/ and move this and the
> > > existing drivers/misc/ocxl/ bits there.
> >
> > Is there any other justification for this we can think of apart from
> > not
> > wanting to put this driver in the nvdimm directory? OpenCAPI drivers
> > aren't really a category of driver unto themselves.
>
> There is a precedent for bus-based dirs, eg. drivers/(ide|w1|spi) all
> contain drivers for both controllers & connected devices.
>
> Fred, how do you feel about moving the generic OpenCAPI driver out of
> drivers/misc?

Instinctively I don't like the idea of creating a whole opencapi 
directory, as OpenCAPI is a generic bus which is not tightly coupled to 
any particular application area, and drivers for other OpenCAPI devices 
are already spread throughout the tree (e.g. cxlflash in drivers/scsi).


--
Andrew Donnellan              OzLabs, ADL Canberra
ajd@xxxxxxxxxxxxx             IBM Australia Limited