Re: [PATCH v2 01/10] iommu/vt-d: Introduce native SVM capable flag

[Lu Baolu]

Hi,

On 11/19/19 5:48 AM, Jacob Pan wrote:
> On Mon, 18 Nov 2019 21:33:53 +0100
> Auger Eric <eric.auger@xxxxxxxxxx> wrote:
>
> > Hi Jacob,
> >
> > On 11/18/19 8:42 PM, Jacob Pan wrote:
> > > Shared Virtual Memory(SVM) is based on a collective set of hardware
> > > features detected at runtime. There are requirements for matching
> > > CPU and IOMMU capabilities.
> > >
> > > This patch introduces a flag which will be used to mark and test the
> > > capability of SVM.
> > >
> > > Signed-off-by: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx>
> > > Acked-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> > > ---
> > >   include/linux/intel-iommu.h | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/include/linux/intel-iommu.h
> > > b/include/linux/intel-iommu.h index ed11ef594378..63118991824c
> > > 100644 --- a/include/linux/intel-iommu.h
> > > +++ b/include/linux/intel-iommu.h
> > > @@ -433,6 +433,7 @@ enum {
> > >   
> > >   #define VTD_FLAG_TRANS_PRE_ENABLED	(1 << 0)
> > >   #define VTD_FLAG_IRQ_REMAP_PRE_ENABLED	(1 << 1)
> > > +#define VTD_FLAG_SVM_CAPABLE		(1 << 2)
> >
> > I think I would rather squash this into the next patch as there is no
> > user here.
> Sure, I don't have strong preference. Baolu, what is your call?

It's okay for me.

Best regards,
baolu