Re: [PATCH v3 0/7] perf/probe: Support multiprobe and immediates with fixes

[Arnaldo Carvalho de Melo]

Em Mon, Nov 18, 2019 at 05:11:40PM +0900, Masami Hiramatsu escreveu:
> Hi Arnaldo,
> 
> This is the 3rd version of the multiprobe support on perf probe
> including some fixes about "representive lines"
> 
> The previous thread is here:
> 
> https://lkml.kernel.org/r/157314406866.4063.16995747442215702109.stgit@devnote2
> 
> On the previous thread, we discussed some issues about incorrect line
> information shown by perf probe. I finally fixed those by introducing
> an idea of "representive line" -- a line which has a unique address
> (no other lines shares the same address) or a line which has the least
> line number among lines sharing same address. Now perf probe only shows
> such representive lines can be probed([1/7][3/7]), and if user tries to
> probe other non representive lines, it shows which line user should
> probe ([2/7]). The rest of patches in the series are same as v2 (except
> for [4/7], example output is updated)
> 
> This can be applied on top of perf/core.

Thanks, applied everything, only the two last patches I didn't test, the
kernel in this machine doesn't have the features it needs, we can fix
things if some problem lurks there.

- Arnaldo
 
> Thank you,
> 
> ---
> 
> Masami Hiramatsu (7):
>       perf probe: Show correct statement line number by perf probe -l
>       perf probe: Verify given line is a representive line
>       perf probe: Do not show non representive lines by perf-probe -L
>       perf probe: Generate event name with line number
>       perf probe: Support multiprobe event
>       perf probe: Support DW_AT_const_value constant value
>       perf probe: Trace a magic number if variable is not found
> 
> 
>  tools/perf/util/dwarf-aux.c    |   62 ++++++++++++++++++++-
>  tools/perf/util/probe-event.c  |   19 ++++++-
>  tools/perf/util/probe-event.h  |    3 +
>  tools/perf/util/probe-file.c   |   14 +++++
>  tools/perf/util/probe-file.h   |    2 +
>  tools/perf/util/probe-finder.c |  116 +++++++++++++++++++++++++++++++++++++++-
>  tools/perf/util/probe-finder.h |    1 
>  7 files changed, 206 insertions(+), 11 deletions(-)
> 
> --
> Masami Hiramatsu (Linaro) <mhiramat@xxxxxxxxxx>

-- 

- Arnaldo