Re: [PATCH 0/2] add new DRM_DEV_WARN macro

[Sean Paul]

On Mon, Nov 18, 2019 at 09:03:20PM +0100, Daniel Vetter wrote:
> On Mon, Nov 18, 2019 at 8:24 PM Sean Paul <sean@xxxxxxxxxx> wrote:
> > On Fri, Nov 15, 2019 at 01:52:53PM +0200, Jani Nikula wrote:
> > > On Thu, 14 Nov 2019, Wambui Karuga <wambui.karugax@xxxxxxxxx> wrote:
> > > > This adds a new DRM_DEV_WARN helper macro for warnings log output that include
> > > > device pointers. It also includes the use of the DRM_DEV_WARN macro in
> > > > drm/rockchip to replace dev_warn.
> > >
> > > I'm trying to solicit new struct drm_device based logging macros, and
> > > starting to convert to those. [1]
> > >
> >
> > This sounds good to me, I'd much prefer the non-caps versions of these
> > functions. So let's wait for those to bubble up and then convert rockchip to
> > drm_dev_*
> 
> Care to ack Jani's patch directly, so this is all formal?

I just time traveled to last week and acked the whole series :)

Sean

> 
> Jani, can you pls also add a todo.rst patch on top to adjust the
> relevant item to the new color choice?
> 
> Wambui, I guess slight change of plans, it happens ...
> 
> Cheers, Daniel
> 
> >
> > Sean
> >
> > > BR,
> > > Jani.
> > >
> > >
> > > [1] http://patchwork.freedesktop.org/patch/msgid/63d1e72b99e9c13ee5b1b362a653ff9c21e19124.1572258936.git.jani.nikula@xxxxxxxxx
> > >
> > >
> > >
> > >
> > > >
> > > > Wambui Karuga (2):
> > > >   drm/print: add DRM_DEV_WARN macro
> > > >   drm/rockchip: use DRM_DEV_WARN macro in debug output
> > > >
> > > >  drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++-
> > > >  include/drm/drm_print.h              | 9 +++++++++
> > > >  2 files changed, 11 insertions(+), 1 deletion(-)
> > >
> > > --
> > > Jani Nikula, Intel Open Source Graphics Center
> >
> > --
> > Sean Paul, Software Engineer, Google / Chromium OS
> 
> 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch

-- 
Sean Paul, Software Engineer, Google / Chromium OS