RE: [PATCH 03/13] exfat: add inode operations

[Namjae Jeon]

> â
> > +++ b/fs/exfat/inode.c
> â
> > +static int exfat_create(struct inode *dir, struct dentry *dentry, umode_t
> mode,
> > +		bool excl)
> > +{
> â
> +out:
> +	mutex_unlock(&EXFAT_SB(sb)->s_lock);
> 
> Can the label âunlockâ be more appropriate?
Yep, Will change it.
> 
> 
> > +static struct dentry *exfat_lookup(struct inode *dir, struct dentry
> *dentry,
> > +		unsigned int flags)
> > +{
> â
> > +error:
> > +	mutex_unlock(&EXFAT_SB(sb)->s_lock);
> 
> Would you like to use the label âunlockâ also at this place (and similar
> ones)?
Yep, Will change all ones.

> 
> 
> > +static int exfat_search_empty_slot(struct super_block *sb,
> > +		struct exfat_hint_femp *hint_femp, struct exfat_chain *p_dir,
> > +		int num_entries)
> > +{
> â
> > +out:
> > +	kfree(clu);
> 
> How do you think about to rename the label to âfree_cluâ?
Yep, Will change it on V2.

Thanks for your review!
> 
> Regards,
> Markus