Re: [PATCH v3 0/5] AMD64 EDAC: Check for nodes without memory, etc.
From: Borislav Petkov
Date: Thu Nov 07 2019 - 10:40:14 EST
On Thu, Nov 07, 2019 at 01:47:53PM +0000, Ghannam, Yazen wrote:
> BTW, what do you think about loading based on PCI devices? The module
> used to do this. I ask because I'm starting to see that future systems may
> re-use PCI IDs, and this indicates the same level of hardware support.
The reason we switched to family-based autoloading was that almost
every new platform would add a new PCI device ID, which would require
enablement work...
> Just a nit, but this else seems unnecessary right?
Maybe it is easier if you look at the function end in the .c file directly as
diffs can be confusing:
static bool ecc_enabled(struct amd64_pvt *pvt)
{
...
amd64_info("Node %d: DRAM ECC %s.\n",
nid, (ecc_en ? "enabled" : "disabled"));
if (!ecc_en || !nb_mce_en)
return false;
else
return true;
}
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette