Re: [RFC][PATCH] x86, mce, therm_throt: Optimize notifications of thermal throttle
From: Borislav Petkov
Date: Tue Nov 05 2019 - 15:56:30 EST
On Tue, Nov 05, 2019 at 12:36:32PM -0800, Srinivas Pandruvada wrote:
> > That wants to be a bool judging by the context it is used in.
> I can change to bool, just didn't use it
> https://yarchive.net/comp/linux/bool.html
And are you using it in a union or where the size of bool - which is
implementation-specific - plays any role, esp. in your particular use
case?
> They are architectural MSRs and the fact that we are getting called
> means that they are enabled by looking at CPUID bits.
If the CPUID bits guarantees their presence, then the error handling is
not absolutely necessary.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette