On 05.11.2019 21:02, Dan Murphy wrote:
Heiner[...]
On 11/5/19 1:55 PM, Heiner Kallweit wrote:
On 05.11.2019 19:18, Dan Murphy wrote:
Add support for the TI DP83869 Gigabit ethernet phy
device.
The DP83869 is a robust, low power, fully featured
Physical Layer transceiver with integrated PMD
sublayers to support 10BASE-T, 100BASE-TX and
1000BASE-T Ethernet protocols.
Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
---
 drivers/net/phy/Kconfig | 6 +
 drivers/net/phy/Makefile | 1 +
 drivers/net/phy/dp83869.c | 439 +++++++++++++++++++++++++++
 include/dt-bindings/net/ti-dp83869.h | 43 +++
 4 files changed, 489 insertions(+)
 create mode 100644 drivers/net/phy/dp83869.c
 create mode 100644 include/dt-bindings/net/ti-dp83869.h
Maybe we need to understand the use case better to be able to advise.We do read the initial mode from the DT but there was a request to be able to change the mode during runtime.+static int op_mode;A module parameter isn't the preferred option here.
+
+module_param(op_mode, int, 0644);
+MODULE_PARM_DESC(op_mode, "The operational mode of the PHY");
+
You could have more than one such PHY in different configurations.
Other drivers like the Marvell one use the interface mode to
check for the desired mode. Or you could read it from DT.
Will this be needed in production? Or was it requested as debug feature?
There's the option to set PHY registers from userspace, e.g. with phytool.
This could be used for reconfiguring the PHY.
Heiner
[...]