Re: [PATCH net-next 1/4] net: ethernet: stmmac: Add support for syscfg clock
From: David Miller
Date: Mon Nov 04 2019 - 14:33:48 EST
From: Christophe Roullier <christophe.roullier@xxxxxx>
Date: Mon, 4 Nov 2019 14:25:30 +0100
> + if (dwmac->syscfg_clk)
> + goto unprepare_syscfg;
> return ret;
...
> +unprepare_syscfg:
> + clk_disable_unprepare(dwmac->syscfg_clk);
> +
> + return ret;
This is so amazingly silly. You're doing a goto instead of the
clk_disable_unprepare() call itself.
Please don't do this.