Re: [PATCH] reset: brcmstb: Fix resource checks

From: Florian Fainelli
Date: Thu Oct 31 2019 - 23:09:21 EST




On 10/31/2019 8:06 PM, Florian Fainelli wrote:
> The use of IS_ALIGNED() is incorrect, the typical resource we pass looks
> like this: start: 0x8404318, size: 0x30. When using IS_ALIGNED() we will
> get the following 0x8404318 & (0x18 - 1) = 0x10 which is definitively
> not equal to 0.
>
> Replace this with an appropriate check on the start address and the
> resource size to be a multiple of SW_INIT_BANK_SIZE.
>
> Fixes: 77750bc089e4 ("reset: Add Broadcom STB SW_INIT reset controller driver")
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Sorry this fails building on 32-bit because it triggers a 64-bit
division let me go back and fix this...
--
Florian