Re: [PATCH] nvme: change nvme_passthru_cmd64's result field.

From: Christoph Hellwig
Date: Thu Oct 31 2019 - 09:59:08 EST


On Thu, Oct 31, 2019 at 06:55:33AM -0700, Charles Machalow wrote:
> Not quite sure what you mean by check for zero in the ioctl handler. I like
> the idea of being able to use the same struct for either the original or 64
> ioctls from userspace. I don't believe adding the explicit rsvd field
> allows that.

You might like the idea, but it fundamentally is a bad idea. For example
you completely break architectures that do not support unaligned loads
and stores.