Re: [PATCH v2] nvdimm/btt: fix variable 'rc' set but not used

From: Qian Cai
Date: Wed Oct 30 2019 - 17:54:09 EST




> On Oct 30, 2019, at 5:38 PM, Verma, Vishal L <vishal.l.verma@xxxxxxxxx> wrote:
>
> Good find! Since we're not really using rc later, we should just
> simplify this to:
>
> if (btt_map_write(...))
> dev_warn_ratelimited(...)
> goto out_rtt;

Ah, I thought about printing the rc as well at first, but it seems only return -EIO for errors, so I agree with you.