Re: [PATCH v3 07/11] arm64: dts: qcom: sc7180: Add SPMI PMIC arbiter device

[kgunda]

On 2019-10-29 22:11, Stephen Boyd wrote:
> Quoting Rajendra Nayak (2019-10-23 02:02:15)
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi 
> > b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > index 04808a07d7da..6584ac6e6c7b 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > @@ -224,6 +224,25 @@
> >                         };
> >                 };
> >
> > +               spmi_bus: spmi@c440000 {
> > +                       compatible = "qcom,spmi-pmic-arb";
> > +                       reg = <0 0xc440000 0 0x1100>,
>
> Please pad out the registers to 8 numbers. See sdm845.
Ok.. Will address it in the next series.
> > +                             <0 0xc600000 0 0x2000000>,
> > +                             <0 0xe600000 0 0x100000>,
> > +                             <0 0xe700000 0 0xa0000>,
> > +                             <0 0xc40a000 0 0x26000>;
> > +                       reg-names = "core", "chnls", "obsrvr", "intr", 
> > "cnfg";
> > +                       interrupt-names = "periph_irq";
> > +                       interrupts-extended = <&pdc 1 
> > IRQ_TYPE_LEVEL_HIGH>;
>
> This is different than sdm845. I guess pdc is working?
Yes. For SDM845 pdc controller support was not yet added. That's why 
still the GIC interrupt is used.
Where as for SC7180 the same is added with 
https://lore.kernel.org/patchwork/patch/1143335/.

Yes. pdc is working.

> > +                       qcom,ee = <0>;
> > +                       qcom,channel = <0>;
> > +                       #address-cells = <1>;
> > +                       #size-cells = <1>;
> > +                       interrupt-controller;
> > +                       #interrupt-cells = <4>;
> > +                       cell-index = <0>;
> > +               };
> > +