Re: [PATCH 3.16 58/87] cifs: add spinlock for the openFileList to cifsInodeInfo

[Ben Hutchings]

On Mon, 2019-10-28 at 22:19 +0000, Pavel Shilovskiy wrote:
> > -----Original Message-----
> > From: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> > Sent: Wednesday, October 2, 2019 12:07 PM
> > To: linux-kernel@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx
> > Cc: akpm@xxxxxxxxxxxxxxxxxxxx; Denis Kirjanov <kda@xxxxxxxxxxxxxxxxx>; Ronnie Sahlberg <lsahlber@xxxxxxxxxx>; Steven French <Steven.French@xxxxxxxxxxxxx>; Pavel Shilovskiy <pshilov@xxxxxxxxxxxxx>
> > Subject: [PATCH 3.16 58/87] cifs: add spinlock for the openFileList to cifsInodeInfo
> > 
> > 3.16.75-rc1 review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Ronnie Sahlberg <lsahlber@xxxxxxxxxx>
> > 
> > commit 487317c99477d00f22370625d53be3239febabbe upstream.
[...]
> We have recently found regressions in this patch that are addressed in the following two patches:
> 
> cb248819d209d ("cifs: use cifsInodeInfo->open_file_lock while iterating to avoid a panic")
> 1a67c41596575 ("CIFS: Fix use after free of file info structures")
> 
> So, I would suggest either to apply those two patches above or to revert this one.

Thanks for pointing thse out.  I will try to include those in a later
update.

Ben.

-- 
Ben Hutchings
Any sufficiently advanced bug is indistinguishable from a feature.

Attachment: signature.asc
Description: This is a digitally signed message part