[PATCH v3 24/32] mtd: spi-nor: Print error message when the read back test fails

From: Tudor.Ambarus
Date: Tue Oct 29 2019 - 07:17:38 EST


From: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>

Demystify where the EIO error occurs.

Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
---
drivers/mtd/spi-nor/spi-nor.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 5b30fc73fdba..30ce83426266 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -974,7 +974,12 @@ static int spi_nor_write_sr_and_check(struct spi_nor *nor, u8 status_new)
if (ret)
return ret;

- return (nor->bouncebuf[0] != status_new) ? -EIO : 0;
+ if (nor->bouncebuf[0] != status_new) {
+ dev_err(nor->dev, "SR: read back test failed\n");
+ return -EIO;
+ }
+
+ return 0;
}

/**
--
2.9.5