Re: [PATCH AUTOSEL 4.19 095/100] USB: usb-skeleton: fix use-after-free after driver unbind

[Sasha Levin]

On Fri, Oct 18, 2019 at 06:22:05PM -0400, Greg Kroah-Hartman wrote:
> On Fri, Oct 18, 2019 at 06:05:20PM -0400, Sasha Levin wrote:
> > From: Johan Hovold <johan@xxxxxxxxxx>
> >
> > [ Upstream commit 6353001852776e7eeaab4da78922d4c6f2b076af ]
> >
> > The driver failed to stop its read URB on disconnect, something which
> > could lead to a use-after-free in the completion handler after driver
> > unbind in case the character device has been closed.
> >
> > Fixes: e7389cc9a7ff ("USB: skel_read really sucks royally")
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> > Link: https://lore.kernel.org/r/20191009170944.30057-3-johan@xxxxxxxxxx
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > ---
> >  drivers/usb/usb-skeleton.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> This file does not even get built in the kernel tree, no need to
> backport anything for it :)

I'll drop it, but you're taking patches for this driver:
https://lore.kernel.org/patchwork/patch/1140673/ .

--
Thanks,
Sasha