Re: [PATCH 3/3] mtd: spi-nor: Add support for w25q256jw

[Manivannan Sadhasivam]

Hi Vignesh,

On Mon, Oct 28, 2019 at 05:20:40PM +0530, Vignesh Raghavendra wrote:
> Hi,
> 
> On 24/10/19 8:12 PM, Manivannan Sadhasivam wrote:
> > Add MTD support for w25q256jw SPI NOR chip from Winbond. This chip
> > supports dual/quad I/O mode with 512 blocks of memory organized in
> > 4KB sectors. 
> 
> 512 blocks of memory organized into 64KB sector, right? In additional
> flash also supports 4KB small sector.
> 

Yeah, the wording is wrong here. Will fix it.

Thanks,
Mani

> Regards
> Vignesh
> 
> > The device has been validated using Thor96 board.
> 
> 
> > Cc: Marek Vasut <marek.vasut@xxxxxxxxx>
> > Cc: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
> > Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
> > Cc: Brian Norris <computersforpeace@xxxxxxxxx>
> > Cc: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> > Cc: Richard Weinberger <richard@xxxxxx>
> > Cc: Vignesh Raghavendra <vigneshr@xxxxxx>
> > Cc: linux-mtd@xxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Darshak Patel <darshak.patel@xxxxxxxxxxxxxx>
> > [Mani: cleaned up for upstream]
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > ---
> >  drivers/mtd/spi-nor/spi-nor.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> > index 1d8621d43160..2c25b371d9f0 100644
> > --- a/drivers/mtd/spi-nor/spi-nor.c
> > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > @@ -2482,6 +2482,8 @@ static const struct flash_info spi_nor_ids[] = {
> >  	{ "w25q256", INFO(0xef4019, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> >  	{ "w25q256jvm", INFO(0xef7019, 0, 64 * 1024, 512,
> >  			     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> > +	{ "w25q256jw", INFO(0xef6019, 0, 64 * 1024, 512,
> > +			     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> >  	{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> >  			SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> >  
> >