On Mon, Oct 28, 2019 at 08:39:53AM +0100, Christoph Hellwig wrote:
On Sun, Oct 27, 2019 at 07:41:56PM -0700, Guenter Roeck wrote:> I think it's nvme-cli requires root, where this conveniently doesn't
nvme devices report temperature information in the controller information
(for limits) and in the smart log. Currently, the only means to retrieve
this information is the nvme command line interface, which requires
super-user privileges.
At the same time, it would be desirable to use NVME temperature information
for thermal control.
This patch adds support to read NVME temperatures from the kernel using the
hwmon API and adds temperature zones for NVME drives. The thermal subsystem
can use this information to set thermal policies, and userspace can access
it using libsensors and/or the "sensors" command.
So these reported values seem to generate some interest. Adding Akinobu
Mita who also planned to wire them up to the thermal framework. I don't
really know either upper layer so I'm not sure which is the right one,
but with this just like with the previous series I am quite worried that
we add a lot of kernel boilerplate code for information people can
trivially get using nvme-cli.
need those elevated rights.
I'm not familiar with either upper level framework either; my only reviewMakes sense. I'll address that in v2.
comment for this patch is to use devm_kfree() for the error cases.