Re: [PATCH 03/15] riscv: abstract out CSR names for supervisor vs machine mode

From: Christoph Hellwig
Date: Mon Oct 28 2019 - 04:12:49 EST


On Fri, Oct 18, 2019 at 04:55:02PM -0700, Paul Walmsley wrote:
> The basic idea looks good to me, but some of the X-prefixing can make the
> code difficult to read. The Xret macro looks fine to me, as do the
> XIE_XTIE macros. But I think it would be better if the X-prefixes on the
> rest of the macros and structure members could be dropped. This also
> aligns with the way that these registers often are discussed at the
> architectural level; e.g., we'd talk about the "epc" registers, not the
> "xepc" registers.

If we get of the x we should get rid of all of them. I'll make sure it
is all gone for the next version.