[RFC PATCH] nvdimm: scm_get() can be static

From: kbuild test robot
Date: Sun Oct 27 2019 - 21:13:12 EST



Fixes: 0d40f55b9035 ("nvdimm: Add driver for OpenCAPI Storage Class Memory")
Signed-off-by: kbuild test robot <lkp@xxxxxxxxx>
---
ocxl-scm.c | 4 ++--
ocxl-scm_internal.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/nvdimm/ocxl-scm.c b/drivers/nvdimm/ocxl-scm.c
index f4e6cc022de8a..c169cb0bc71d4 100644
--- a/drivers/nvdimm/ocxl-scm.c
+++ b/drivers/nvdimm/ocxl-scm.c
@@ -733,7 +733,7 @@ static void scm_put(struct scm_data *scm_data)
put_device(&scm_data->dev);
}

-struct scm_data *scm_get(struct scm_data *scm_data)
+static struct scm_data *scm_get(struct scm_data *scm_data)
{
return (get_device(&scm_data->dev) == NULL) ? NULL : scm_data;
}
@@ -2142,7 +2142,7 @@ static int scm_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
return -ENXIO;
}

-struct pci_driver scm_pci_driver = {
+static struct pci_driver scm_pci_driver = {
.name = "ocxl-scm",
.id_table = scm_pci_tbl,
.probe = scm_probe,
diff --git a/drivers/nvdimm/ocxl-scm_internal.c b/drivers/nvdimm/ocxl-scm_internal.c
index e7c247835817b..ee11fb72e1ecd 100644
--- a/drivers/nvdimm/ocxl-scm_internal.c
+++ b/drivers/nvdimm/ocxl-scm_internal.c
@@ -64,8 +64,8 @@ int scm_admin_command_request(struct scm_data *scm_data, u8 op_code)
return scm_command_request(scm_data, &scm_data->admin_command, op_code);
}

-int scm_command_response(const struct scm_data *scm_data,
- const struct command_metadata *cmd)
+static int scm_command_response(const struct scm_data *scm_data,
+ const struct command_metadata *cmd)
{
u64 val;
u16 id;